backend/tests/test_resume_draft_api.py (1)

85-160: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Missing test: re-enqueue guard when a draft task is already in-progress.

The router's try_reset_to_pending short-circuits and returns the existing cache.status (not "pending") instead of re-dispatching when a task is already pending/processing. This idempotency path prevents duplicate dispatch/re-billing but isn't covered by any test in this file.

♻️ Suggested test addition

def test_resume_draft_run_returns_existing_status_when_already_pending(client: TestClient) -> None:
    """既に pending/processing 中なら再ディスパッチせず現在のステータスを返す。"""
    headers = auth_header(client, github_id=1)
    _seed_link_data(client._db_session)
    user = client._db_session.query(User).filter_by(username="testuser").one()
    client._db_session.add(ResumeDraftCache(user_id=user.id, status="processing"))
    client._db_session.commit()

    res = client.post("/api/agent/resume-draft/run", json={"model": "haiku"}, headers=headers)

    assert res.status_code == 202
    assert res.json()["status"] == "processing"

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@backend/tests/test_resume_draft_api.py` around lines 85 - 160, Add a test for
the idempotent re-enqueue guard in the resume draft flow: when an existing
ResumeDraftCache is already in "pending" or "processing", the request should not
dispatch again and should return the current cache status instead of "pending".
Extend backend/tests/test_resume_draft_api.py with a case around
test_resume_draft_run_enqueues and try_reset_to_pending that seeds link data,
inserts a ResumeDraftCache in processing state, calls
/api/agent/resume-draft/run, and asserts the 202 response echoes "processing"
from the response payload.

web/src/hooks/useResumeDraftPdf.ts (1)

92-105: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Stale previewUrl not cleared when re-generating.

Unlike the prior synchronous flow, generate() no longer resets previewUrl before enqueueing a new task, so an old preview can remain visible/stale until the new one completes. Self-recovers once loadPreview runs, but could confuse users mid-regeneration.

🩹 Suggested fix

   const generate = async () => {
     if (generating) return;
     setGenerating(true);
     setError(null);
+    updatePreviewUrl(null);
     try {
       await startResumeDraft(model);
       startPolling();

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@web/src/hooks/useResumeDraftPdf.ts` around lines 92 - 105, The generate flow
in useResumeDraftPdf should clear any existing previewUrl before starting a new
draft generation, since the async enqueue/polling path can leave a stale preview
visible until loadPreview updates it. Update generate() to reset the preview
state alongside setGenerating/setError before calling startResumeDraft(model),
so the UI doesn’t show an outdated preview during regeneration.

web/src/api/agent.ts (1)

25-53: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

ADR-0020 に更新してください
この非同期ドラフトフローの JSDoc は ADR-0018 ではなく ADR-0020 を参照するように揃えてください。関連するソースコメントも同じ番号に合わせると、生成される API ドキュメントとのずれもなくなります。

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@web/src/api/agent.ts` around lines 25 - 53, The JSDoc references in the
resume draft async flow are still pointing to ADR-0018, so update the comments
on startResumeDraft, getResumeDraftStatus, and fetchResumeDraftPdfBlobUrl to
reference ADR-0020 instead. Keep the surrounding descriptions the same, and make
sure any related source comments for this flow use the same ADR number so the
generated API docs stay consistent.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes